Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix background image upload #40

Closed
swouf opened this issue Mar 18, 2022 · 1 comment · Fixed by #38
Closed

Fix background image upload #40

swouf opened this issue Mar 18, 2022 · 1 comment · Fixed by #38
Assignees
@swouf
Labels
bug 🪲 Something isn't working help wanted Extra attention is needed priority ⚠️ Give priority to this issue
Milestone
Port to new Graas...

Comments

@swouf
Copy link
Contributor

swouf commented Mar 18, 2022

This has to do with CRA support for CJS which breaks over uppy...

See transloadit/uppy#3376 as a description of the issue and see facebook/create-react-app#12021 as a potential solution.

I already tried to compile https://github.com/joeldenning/create-react-app/tree/cjs-support directly but vulnerability check prevents its use.
@swouf swouf added bug 🪲 Something isn't working help wanted Extra attention is needed priority ⚠️ Give priority to this issue labels Mar 18, 2022
@swouf swouf added this to the Port to new Graasp (v3) milestone Mar 18, 2022
@swouf swouf self-assigned this Mar 18, 2022
@swouf swouf mentioned this issue Mar 21, 2022
Merged
@swouf
Copy link
Contributor Author

swouf commented Mar 21, 2022

Hopefully, commit e1cf13d4102450b30e97831db1a750d8268c42ae will solve this.

@swouf swouf linked a pull request Mar 30, 2022 that will close this issue
26/port v3 #38
Merged
@swouf swouf closed this as completed in #38 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swouf swouf

Labels
bug 🪲 Something isn't working help wanted Extra attention is needed priority ⚠️ Give priority to this issue
Projects
None yet
Milestone
Port to new Graasp (v3)
Development

Successfully merging a pull request may close this issue.

26/port v3 graasp/graasp-app-sticky-notes
1 participant
@swouf