Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade dependencies #23

Closed
pyphilia opened this issue Jun 22, 2022 · 2 comments · Fixed by #31
Closed

Upgrade dependencies #23

pyphilia opened this issue Jun 22, 2022 · 2 comments · Fixed by #31
Assignees
@swouf @pyphilia
Labels
dependencies Pull requests that update a dependency file

Comments

@pyphilia
Copy link
Contributor

And most particularly react and query client.
@pyphilia pyphilia self-assigned this Jun 22, 2022
@pyphilia
Copy link
Contributor Author

It is still not possible to upgrade to react18 because it lacks support of cjs for uppy
facebook/create-react-app#12021

@pyphilia
Copy link
Contributor Author

I will apply the latest solution with react-app-rewired, since apps-query-client is using react-query v4 and it is not compatible with react17. But react18 is not compatible with uppy, so we rewire to allow uppy in react18.

@swouf swouf self-assigned this Jan 20, 2023
@swouf swouf added the dependencies Pull requests that update a dependency file label Jan 20, 2023
@swouf swouf mentioned this issue Jan 20, 2023
Merged
@swouf swouf closed this as completed in #31 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swouf swouf

@pyphilia pyphilia

Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: MUI5, Typescript graasp/graasp-app-file-drop
2 participants
@swouf @pyphilia