Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Improve PWA designsystem site features #290

Closed
6 of 9 tasks
azerella opened this issue Oct 25, 2018 · 2 comments
Closed
6 of 9 tasks

Improve PWA designsystem site features #290

azerella opened this issue Oct 25, 2018 · 2 comments
Labels
accessibility Issue or pull request related to accessibility. enhancement New feature or request.

Comments

@azerella
Copy link
Contributor

azerella commented Oct 25, 2018

Bug report

  • I’ve read and understood the Contributing guidelines and have done my best effort to follow them.
  • I’ve read and agree to the Code of Conduct.
  • I’ve searched for any related issues and avoided creating a duplicate issue.

It seems that the current designsystem site isn't very progressive, there's a few things we can look at:

  • Add /robots.txt to production environment, this was added for staging/testing with the recent nginx_buildpack addition.
  • Add /sitemap.xml this is great for SEO and users looking for a perfect reference of site pages.
  • Add service worker to improve asset caching and offline access
  • Missing /manifest.json
  • Missing <meta description=""/> element
  • aria-* attributes do not match their role, see:
    image and https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA

This issue should be separate into an epic or individual tasks at the least.

@azerella azerella added enhancement New feature or request. accessibility Issue or pull request related to accessibility. labels Oct 25, 2018
@azerella azerella changed the title Improve PWA features Improve PWA designsystem site features Oct 25, 2018
@alex-page
Copy link
Contributor

@azerella
Copy link
Contributor Author

azerella commented May 3, 2019

Closing this as we have other separate issues to address this stuff, e.g #461 #487 #306

@azerella azerella closed this as completed May 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility Issue or pull request related to accessibility. enhancement New feature or request.
Projects
None yet
Development

No branches or pull requests

2 participants