Sync alt-text branches with master #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cher (#927) * fix: fix duplicated data in bam data fetcher and odd triggering timing * chore: format
Adds support for genomicFieldsToConvert in JSON data fetcher
* ci: specify allowed scopes in semantic-pull-request.yml * docs: update CONTRIBUTING.md * docs: change order and wording * docs: force scope and add core and track type scopes * chore: add disallowScope to semantic-pull-request.yml * docs: update CONTRIBUTING.md --------- Co-authored-by: etowahadams <[email protected]>
…ED files (#938) fix(datafetcher): bump tabix version
* feat(data-fetcher): GFF3 with tabix * docs(data-fetcher): add GFF3 example --------- Co-authored-by: Sehi L'Yi <[email protected]>
* chore: working on view ids * chore: working on view ID * chore: use both track IDs and view IDs * chore: more comments * feat: ensure ID to all tracks as well, docs, tests * chore: lint * chore: enable scrolling * chore: no support for responsive tracks * chore: remove duplicate ID assignments * chore: format * chore: fix test
Explains in the contributing doc how the spec compiling works. --- Co-authored-by: Sehi L'Yi <[email protected]>
* add two new API methods: `onNewTrack` and `onNewView`
* Add a `location` Javascript API event which responds to genomic axis changes
…ion in VCF (`DISTPREV`) (#949) * fix: correct DISTPREV calculation for vcf * chore: format * chore: rename var for clarity
* feat: add SVGTrack type * feat: dummy track * feat: dummy track styles * fix: update schema * fix: simplify logic * feat(track): add text stroke properties * fix: update schema * test(core): add test for dummy track compiling * fix(track): put text in the center Co-authored-by: Sehi L'Yi <[email protected]> * fix: remove hardcoded values * feat(track): circular placeholder layout * fix: update schema * feat(api): onNewTrack * docs: add dummy track example * refactor(track): make dummy track type minimal * feat(track): add outline option * fix: filter out circular dummy track * test(compile): dummy track removed if layout circle * fix: shorthand name * fix: update schema --------- Co-authored-by: Sehi L'Yi <[email protected]>
* fix: do not override ID in tracks from views * chore: minor edit to the code * test: add test * chore: cleanup
* fix: rename parameter/value names regarding view ids * docs: add comment statement * chore: remove comment * feat: support mapping between IDs * chore: add tests and fix type import * chore: format * chore: more test * chore: format * chore: call publish * fix: allow overwritting ids if identical combination * chore: add root level ID as well * chore: use id in the lowest track * chore: use structuredClone Co-authored-by: etowahadams <[email protected]> --------- Co-authored-by: etowahadams <[email protected]>
fix: stream issue
Update index.html
…and schema (#959) * refactor: file structure; separate folder for compiler, tracks, api, and schema * fix: fix build and test * chore: more import adjust * chore: more import clean up * fix: fix import of schema * chore: more refactor
Fixes the alignment of rule marks in circular layouts
thomcsmits
merged commit 8827b6a
into
thomcsmits/alt-text-update-with-main
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix # update alt-text branches with master branch to ease future PR
Toward # alt-text
Necessary because of commit 1c2b766 regarding consistent IDs, used in alt-text for updating data.