From 861e92fcdf59828f17ec4a921fcdc30dab7b1679 Mon Sep 17 00:00:00 2001 From: etowahadams Date: Mon, 10 Jun 2024 12:19:27 -0400 Subject: [PATCH 1/3] refactor: change to experimental_specProcessed --- src/core/gosling-component.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/core/gosling-component.tsx b/src/core/gosling-component.tsx index f2c0f972..7be44222 100644 --- a/src/core/gosling-component.tsx +++ b/src/core/gosling-component.tsx @@ -26,7 +26,7 @@ export interface UrlToFetchOptions { type CompiledCallbackFn = ( goslingSpec: gosling.GoslingSpec, higlassSpec: gosling.HiGlassSpec, - _additionalData: { _processedSpec: gosling.GoslingSpec } + experimental: { experimental_processedSpec: gosling.GoslingSpec } ) => void; export interface GoslingCompProps { @@ -122,7 +122,7 @@ export const GoslingComponent = forwardRef((props, } // If a callback function is provided, return compiled information. - props.compiled?.(spec, newHiGlassSpec, { _processedSpec: newGoslingSpec }); + props.compiled?.(spec, newHiGlassSpec, { experimental_processedSpec: newGoslingSpec }); // Change the size of wrapper `
` elements setSize(newSize); From 1e24173351976e05bcce67085ac0a058873f2aab Mon Sep 17 00:00:00 2001 From: etowahadams Date: Wed, 12 Jun 2024 17:13:52 -0400 Subject: [PATCH 2/3] Update src/core/gosling-component.tsx Co-authored-by: SEHI L'YI --- src/core/gosling-component.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/gosling-component.tsx b/src/core/gosling-component.tsx index 7be44222..c95f39b7 100644 --- a/src/core/gosling-component.tsx +++ b/src/core/gosling-component.tsx @@ -26,7 +26,7 @@ export interface UrlToFetchOptions { type CompiledCallbackFn = ( goslingSpec: gosling.GoslingSpec, higlassSpec: gosling.HiGlassSpec, - experimental: { experimental_processedSpec: gosling.GoslingSpec } + experimental: { _processedSpec: gosling.GoslingSpec } ) => void; export interface GoslingCompProps { From 016342c43a077218aa0446222eaf5feca83f0aff Mon Sep 17 00:00:00 2001 From: etowahadams Date: Wed, 12 Jun 2024 17:17:12 -0400 Subject: [PATCH 3/3] fix: change name --- src/core/gosling-component.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/core/gosling-component.tsx b/src/core/gosling-component.tsx index c95f39b7..150df9fc 100644 --- a/src/core/gosling-component.tsx +++ b/src/core/gosling-component.tsx @@ -26,6 +26,7 @@ export interface UrlToFetchOptions { type CompiledCallbackFn = ( goslingSpec: gosling.GoslingSpec, higlassSpec: gosling.HiGlassSpec, + /** @deprecated This is an experimental object that is not intended for production usage. */ experimental: { _processedSpec: gosling.GoslingSpec } ) => void; @@ -122,7 +123,7 @@ export const GoslingComponent = forwardRef((props, } // If a callback function is provided, return compiled information. - props.compiled?.(spec, newHiGlassSpec, { experimental_processedSpec: newGoslingSpec }); + props.compiled?.(spec, newHiGlassSpec, { _processedSpec: newGoslingSpec }); // Change the size of wrapper `
` elements setSize(newSize);