Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rect y position incorrect on circular layout when using x, xe, y encodings #1071

Open
etowahadams opened this issue Jun 6, 2024 · 0 comments
Labels
bug🐛 Something isn't working

Comments

@etowahadams
Copy link
Contributor

When the rect mark is used on a circular layout with x, xe, and y encodings, the y positions are opposite of what they should be:

Compare the position of the rect marks to the other marks:
image

Spec to reproduce:

{"arrangement": "horizontal","assembly": [["chr",100]],"static": true,"title": "rect y positions are wrong","views": [{"arrangement": "horizontal","centerRadius": 0.5,"layout": "circular","views": [{"spacing": 0.1,"tracks": [{"color": {"value": "#CB7AA7"},"data": {"chromosomeField": "chr","genomicFields": ["start","end"],"type": "json","values": [{"chr": "chr","end": 20,"end1": 30,"label": "A","start": 10,"start1": 20,"value": 2},{"chr": "chr","end": 50,"end1": 60,"label": "B","start": 30,"start1": 40,"value": 3},{"chr": "chr","end": 90,"end1": 100,"label": "C","start": 60,"start1": 70,"value": 1}]},"height": 75,"mark": "rule","stroke": {"value": "#CB7AA7"},"style": {"outline": "black","outlineWidth": 1},"width": 75,"x": {"axis": "none","field": "start","type": "genomic"},"xe": {"axis": "none","field": "end","type": "genomic"},"y": {"axis": "none","field": "value","type": "quantitative"}}]},{"spacing": 0.1,"tracks": [{"color": {"value": "#CB7AA7"},"title": "rect","data": {"chromosomeField": "chr","genomicFields": ["start","end"],"type": "json","values": [{"chr": "chr","end": 20,"end1": 30,"label": "A","start": 10,"start1": 20,"value": 2},{"chr": "chr","end": 50,"end1": 60,"label": "B","start": 30,"start1": 40,"value": 3},{"chr": "chr","end": 90,"end1": 100,"label": "C","start": 60,"start1": 70,"value": 1}]},"height": 75,"mark": "rect","size": {"value": 10},"stroke": {"value": "#CB7AA7"},"style": {"outline": "black","outlineWidth": 1},"width": 75,"x": {"axis": "none","field": "start","type": "genomic"},"xe": {"axis": "none","field": "end","type": "genomic"},"y": {"axis": "none","field": "value","type": "quantitative"}}]},{"spacing": 0.1,"tracks": [{"color": {"value": "#CB7AA7"},"data": {"chromosomeField": "chr","genomicFields": ["start","end"],"type": "json","values": [{"chr": "chr","end": 20,"end1": 30,"label": "A","start": 10,"start1": 20,"value": 2},{"chr": "chr","end": 50,"end1": 60,"label": "B","start": 30,"start1": 40,"value": 3},{"chr": "chr","end": 90,"end1": 100,"label": "C","start": 60,"start1": 70,"value": 1}]},"height": 75,"mark": "triangleLeft","size": {"value": 7},"stroke": {"value": "#CB7AA7"},"style": {"outline": "black","outlineWidth": 1},"width": 75,"x": {"axis": "none","field": "start","type": "genomic"},"xe": {"axis": "none","field": "end","type": "genomic"},"y": {"axis": "none","field": "value","type": "quantitative"}}]}]}],"xDomain": {"chromosome": "chr","interval": [0,100]}}
@etowahadams etowahadams added the bug🐛 Something isn't working label Jun 6, 2024
@etowahadams etowahadams changed the title rect y position incorrect on circular layout rect y position incorrect on circular layout when using x, xe, y encodings Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant