-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update min go version #721
Conversation
Signed-off-by: jonathan <[email protected]>
fb736a9
to
00eb807
Compare
Just thought I'd mention this will probably break windows 7 compatiblity. Best regards! |
Currently the repo states "We support the current and previous major Go release". But your point is still valid. Do you guys have stats on where your code runs? Our distinct (Windows) environments where I see our code running is:
|
Heh, I'm like "who is still running server 2012?". Turns out it is an old test system of ours that is still running :) |
Would it make sense to add a release (not selected as the latest release) tagged like "gov20" or something before applying the change? Then you could do like |
I don't think we need a separate tag as long as we indicate it in the changelog and readme. Users are free to pin v0.5.3 as the last version supporting the older Windows versions. |
I agree. Those bumping into this issue should quickly find their way towards the correct version. We just bumped into the limitation for windows 7 support at some clients with some legacy hardware as our software was built with go 1.22. You'll find a lot of legacy OSes in a lot of industries. We've switched back to 1.20 for now.
|
Closing this and will create a new PR clarifying that while we will build and test on newer Go versions, we will maintain the ability to build on 1.20 for the time being. |
Update min go version to 1.21