Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New API implementation: Routes API #1254

Open
robery567 opened this issue Aug 28, 2024 · 2 comments · May be fixed by #1255
Open

New API implementation: Routes API #1254

robery567 opened this issue Aug 28, 2024 · 2 comments · May be fixed by #1255
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@robery567
Copy link

Is your feature request related to a problem? Please describe.
It would be really helpful to directly implement the RoutesAPI into this package.

Describe the solution you'd like
I have realised the necessary modifications and I am considering opening a PR for it.

Describe alternatives you've considered
None.

Additional context
None
@robery567 robery567 added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 28, 2024
@robery567 robery567 linked a pull request Aug 28, 2024 that will close this issue
Open
4 tasks
@usefulthink
Copy link
Contributor

See here: #1105

The new routes API does have its own package here: https://github.com/googleapis/google-cloud-node/tree/main/packages/google-maps-routing and

@robery567
Copy link
Author

I saw it, but as I already have this package implemented in one of our internal services, it was much easier to implement it directly in this package too, so we won't have to switch packages and implement a new one 😀.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement Routes API robery567/google-maps-services-js
2 participants
@usefulthink @robery567