Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sortedSourceIdentifiers to a more general location #1850

Closed
ollimeier opened this issue Dec 11, 2024 · 1 comment · Fixed by #1855
Closed

Move sortedSourceIdentifiers to a more general location #1850

ollimeier opened this issue Dec 11, 2024 · 1 comment · Fixed by #1855
Assignees
@ollimeier

Comments

@ollimeier
Copy link
Collaborator

ollimeier commented Dec 11, 2024 •
edited by justvanrossum
Loading

(This is needed for #102, #1849)
@ollimeier ollimeier self-assigned this Dec 11, 2024
@justvanrossum
Copy link
Collaborator

Let's make it a method on FontController:

fontController.getSortedSourceIdentifiers()

No arguments, the implementation will use this.sources and this.fontAxes and mapAxesFromUserSpaceToSourceSpace(). (this is the font controller instance).

@justvanrossum justvanrossum moved this to 📋 Backlog in Fontra Project Dec 11, 2024
@ollimeier ollimeier mentioned this issue Dec 15, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Fontra Project Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ollimeier ollimeier

Labels
None yet
Projects
Fontra Project
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move sortedSourceIdentifiers to FontController googlefonts/fontra
2 participants
@justvanrossum @ollimeier