Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[export] Committer name not reliable when editing from the backend. #2

Open
justvanrossum opened this issue Oct 22, 2021 · 10 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@justvanrossum
Copy link
Collaborator

It's been apparent for a while that the user name added to the commit message is not precise: it appears to often add more names than were actually involved in the change. With the incremental export, this becomes even clearen. In this case it even lists a person who hasn't worked on the project for a while:
https://github.com/BlackFoundryCom/gs-cjk-rcjk/commit/e6278c3c55446a41d8325e4b698aba3bdda59a12

@fabiocaccamo
Copy link
Collaborator

@justvanrossum thank you for reporting this.

Looking the back-end, it is clear that the wrong name involved in the change is the author of the last change to the Glyphs Composition, even if the last change to the Glyphs Composition has been done months ago (in the commit there is not a modified glyphsComposition.json file.

@fabiocaccamo fabiocaccamo added the bug Something isn't working label Oct 25, 2021
@fabiocaccamo fabiocaccamo self-assigned this Oct 25, 2021
@justvanrossum
Copy link
Collaborator Author

Any progress on this?

I noticed that when editing directly in the DB web front end, the user name is not recorded, either. Eg. I made this change (in the DB web front end), but I am not listed: https://github.com/BlackFoundryCom/gs-cjk-rcjk/commit/e474a2ef9bb0da648339282c0fec401fe522d055

@fabiocaccamo
Copy link
Collaborator

fabiocaccamo commented Dec 22, 2021

@justvanrossum there is not any progress for now.

This project was created to be used via API, the users that make changes using the backend are not recorded.

@justvanrossum
Copy link
Collaborator Author

But it is possible to edit via the DB front end, so the user should be recorded there as well.

@fabiocaccamo
Copy link
Collaborator

It is possible for you, only because you have enough permissions, normal users can't do it.

@justvanrossum
Copy link
Collaborator Author

Still, the git commit should show my name, and not two people who had nothing to do with this change.

@justvanrossum
Copy link
Collaborator Author

Let's separate two issues here:

  • Committer name is not reliable, when using the API properly
  • Committer name is not available when editing data via the django web UI

The former is a bug that should be fixed, the latter can be filed as a feature request with a low priority.

@justvanrossum
Copy link
Collaborator Author

It also gets confused if more than one client is involved:
image

@fabiocaccamo
Copy link
Collaborator

fabiocaccamo commented Dec 1, 2022

The number of clients is not relevant because the users database is the same.
There is a distinct on users involved, probably you are using two different users with the same first name / last name.

@fabiocaccamo
Copy link
Collaborator

fabiocaccamo commented Dec 1, 2022

I confirm it, two different users with the same first name / last name but different usernames:

Screenshot 2022-12-01 at 10 05 51

@fabiocaccamo fabiocaccamo changed the title [export] Committer name not reliable [export] Committer name not reliable when editing from the backend. Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants