Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage testbench should "close connection" after every request #484

Open
anshuldavid13 opened this issue Mar 31, 2023 · 0 comments
Open
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@anshuldavid13
Copy link

ISSUE FACED:
Retry conformance tests were failing for dotnet on being deployed on Github CI. The issue was flaky in the test suite. The error was:
" System.Net.Http.HttpRequestException : An error occurred while sending the request.
---- System.IO.IOException : The response ended prematurely. "

POSSIBLE SOLUTION:
Change the testbench to use a different worker type that supports keep-alive connections (and probably extend the default keep-alive time to 15 seconds or similar)
OR
Work out why HttpClient isn't reliably detecting the connection closing, and fix that (so that it just automatically uses a new connection)

Please refer to b/275276459 for more details and examples

@anshuldavid13 anshuldavid13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant