Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable skipped TestTestbenchContinueAfterFaultInjection tests on Windows #454

Open
anuragsrivstv opened this issue Jan 18, 2023 · 0 comments
Open

Enable skipped TestTestbenchContinueAfterFaultInjection tests on Windows #454

anuragsrivstv opened this issue Jan 18, 2023 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@anuragsrivstv
Copy link
Contributor

anuragsrivstv commented Jan 18, 2023 •
edited
Loading

On implementing Storage Testbench's Windows support using waitress, unit tests test_repeated_broken_stream_faults_by_header and test_repeated_error_after_256K_faults_by_header in TestTestbenchContinueAfterFaultInjection is intermittently failing on Windows.

Right now these tests' assert has been skipped for Windows, but we need to identify that what is the root cause for these failures on Windows and then enable the test again after fixing it.

PS: On non-windows platform, all unit tests are running.
@anuragsrivstv anuragsrivstv added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 18, 2023
@anuragsrivstv anuragsrivstv mentioned this issue Jan 19, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anuragsrivstv