Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC UpdateObject not clearing Object encryption_config when field empty in request #400

Open
isaiahgama opened this issue Sep 7, 2022 · 0 comments
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@isaiahgama
Copy link

When making an update object request and leaving the encryption_config empty, the object's encryption_config is not being cleared, and is incorrectly returning the existing encryption_config.

Example:
UpdateObject request:
bucket {
name: "projects/_/buckets/testbucket"
encryption {
}
}
update_mask {
paths: "encryption"
}

The above request should clear the config and return the cleared encryption_config as in the bucket below.

Expected response bucket:
blob_v2_bucket {
metadata_generation: 3
project: "projects/123456789"
location: "EU"
storage_class: "STANDARD"
encryption_config {
}
}

However, it is instead returning the existing encryption_config without clearing the fields as in the bucket below.

Actual response bucket:
blob_v2_bucket {
metadata_generation: 3
project: "projects/123456789"
location: "EU"
storage_class: "STANDARD"
encryption_config {
default_kms_key_name: "a/default/test/key"
}
}

@isaiahgama isaiahgama added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

1 participant