Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for x-goog-emulator-instructions #332

Open
5 of 8 tasks
coryan opened this issue May 5, 2022 · 0 comments
Open
5 of 8 tasks

Remove support for x-goog-emulator-instructions #332

coryan opened this issue May 5, 2022 · 0 comments
Labels
type: cleanup An internal cleanup or hygiene concern.

Comments

@coryan
Copy link
Contributor

coryan commented May 5, 2022

Most likely, this is used only by the C++ client library, and the implementation is pretty ugly. The Cloud C++ team is planning to change their tests to use x-test-id. After that happens and we confirm that the other libraries do not use it either, we can remove the code.

The following libraries are known not to use it:

  • Java
  • Go
  • Python
  • Node
  • Ruby
  • PHP
  • C#
  • C++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Development

No branches or pull requests

1 participant