Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate whether this workaround is still needed re: dropping resource header #1918

Open
meredithslota opened this issue Oct 16, 2023 · 0 comments
Open

Investigate whether this workaround is still needed re: dropping resource header #1918

meredithslota opened this issue Oct 16, 2023 · 0 comments
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API.

Comments

@meredithslota
Copy link

nodejs-firestore/owlbot.py

Line 33 in 7a9d17b

# Fix dropping of google-cloud-resource-header

The code above references a workaround that we implemented because the GAPIC library was dropping the resource header (circa 2018). I think that this issue has been addressed in later versions, and if we can remove this it will simplify the post-processing we have to do.
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@meredithslota