Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tests): enable Windows testing for the whole test suite #556

Open
bshaffer opened this issue Jun 1, 2024 · 0 comments
Open

feat(tests): enable Windows testing for the whole test suite #556

bshaffer opened this issue Jun 1, 2024 · 0 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@bshaffer
Copy link
Contributor

bshaffer commented Jun 1, 2024

In our Github Actions workflow, we add a filter for GCECredentialsTests when running on Windows. This is because the tests don't run as expected on Windows. I doubt this is because of a bug in the library - it's probably just a bug / platform difference in the test! But we should look into it, and enable Windows testing across the whole test suite.

run: vendor/bin/phpunit ${{ matrix.os == 'windows-latest' && '--filter GCECredentialsTest' || '' }}

@bshaffer bshaffer added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants