Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with psr/cache 3.0 #342

Closed
akalongman opened this issue Jun 12, 2021 · 5 comments
Closed

Add compatibility with psr/cache 3.0 #342

akalongman opened this issue Jun 12, 2021 · 5 comments
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@akalongman
Copy link

I am not able to install this package, because this requires a downgrading of my psr/cache from 3.0 to 1.0

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 14, 2021
@jdpedrie jdpedrie added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Jun 14, 2021
@bshaffer
Copy link
Contributor

This update will require a BC-break, so we should target it for v2.0 (see #322)

@akalongman What are you using google/auth for? As a stand-alone library, or as part of another library?

@bshaffer
Copy link
Contributor

After looking into this, compatibility with psr/cache:3.0 will be difficult because it requires incompatibility with psr/cache:1.0. This means we'd essentially have to require PHP 8.0 to support it.

Another option would be to have two of every psr/cache-implementing classes. I am not a huge fan of this approach, but I don't see another way.

@akalongman
Copy link
Author

@bshaffer I use this package with google apiclient.

@bshaffer
Copy link
Contributor

@akalongman we've added support for psr/cache:2.0 in #344. As long as the library you're using also allows 2.0 then this will work without an issue once we tag our next release.

@bshaffer
Copy link
Contributor

bshaffer commented Jun 22, 2021

fixed in #348

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants