Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributed tracing with TextMapPropagator #453

Open
rlebran opened this issue May 21, 2024 · 3 comments
Open

Distributed tracing with TextMapPropagator #453

rlebran opened this issue May 21, 2024 · 3 comments

Comments

@rlebran
Copy link

rlebran commented May 21, 2024

Hi,
Is there any way of using tarpc with a TextMapPropagator to propagate opentelemetry headers or to extend the tracing context allowing more properties to pass by (with an HashMap for example)?
This would allow custom opentelemetry implementation to work with tarpc (Datadog for example).

@tikue
Copy link
Collaborator

tikue commented Aug 12, 2024

Thanks for your question! Apologies for the delay in responding.

I don't think this is supported by tarpc today. Can you provide an example of properties that are needed by Datadog? Their docs suggest Datadog supports the W3C trace context standard, so I assume there is some support already, based on what tarpc makes available to Opentelemetry?

@rlebran
Copy link
Author

rlebran commented Aug 15, 2024

Hi !
In my current datadog implementation few custom headers are required: x-datadog-trace-id, x-datadog-parent-id and x-datadog-sampling-priority.
I was looking at something like TextMapPropagator to pass those properties automatically at the bounds of my services. To do so I thing tarpc would need to support some kind of metadata / headers which is not the case right now.
But looking at the doc you linked, it might not be necessary anymore !

@tikue
Copy link
Collaborator

tikue commented Aug 15, 2024

Cool, give it a shot and let me know if there are any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants