Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Python3.9+ (update: already done in source.. release out of date) #299

Open
JJones780 opened this issue Dec 3, 2024 · 3 comments

Comments

@JJones780
Copy link

I'm on Python 3.11.
In spatialmedia/gui.py I had to change

import tkFileDialog
import tkMessage

to

from tkinter import filedialog
from tkinter import tkmessage

and
from TKinter import *
to
from tkinter import *

and all 2 instances of tkFileDialog to filedialog
and all 1 instance of tkMessageBox to messagebox

Then in spatialdata/metadata_utils.py
I changed
for child in parsed_xml.getchildren():
to
for child in parsed_xml:

@jamiesonpepper
Copy link
Collaborator

jamiesonpepper commented Dec 4, 2024

I believe this is currently working the same in main/master but requires you to pull and build the .spec file via pyinstaller. I tested with 3.10 on Linux, Mac (older version Mohave I think?) and Windows 10, but have not released new binaries as I am working on a web-based UI in a Docker container.

Refs for fixes in main:

https://github.com/google/spatial-media/pull/227/files
https://github.com/google/spatial-media/pull/262/files

@JJones780 JJones780 changed the title Upgrade to Python3.9+ Upgrade to Python3.9+ (update: already done in source.. release out of date) Dec 16, 2024
@JJones780
Copy link
Author

my apologies, I had just downloaded the recent binaries instead of the source tree.
Maybe this should be left open for others until a new release is made?

@jamiesonpepper
Copy link
Collaborator

I can leave it open, but I don't intend to make a new release for it and will be focusing on building out a Web UI to compliment the Docker implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants