Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review destructors in Oboe #2030

Open
philburk opened this issue Jun 8, 2024 · 0 comments
Open

Review destructors in Oboe #2030

philburk opened this issue Jun 8, 2024 · 0 comments
Assignees

Comments

@philburk
Copy link
Collaborator

philburk commented Jun 8, 2024

Make sure destructors do not call any virtual functions.
They were reviewed on 2024-06-08. Only empty or default destructors found.

Use "= default" in:
src/common/FixedBlockAdapter.h
src/common/MonotonicCounter.h
src/opensles/AudioInputStreamOpenSLES.cpp

Move "= default" from .cpp to .h:
src/flowgraph/MultiToManyConverter.cpp
src/flowgraph/ChannelCountConverter.cpp

Maybe add destructor to:
src/flowgraph/Limiter.h
src/flowgraph/SinkI16.h
src/flowgraph/SinkI24.h
src/flowgraph/SourceI24.h
src/opensles/AudioStreamBuffered.h
src/common/DataConversionFlowGraph.h
src/common/SourceFloatCaller.h
src/common/SourceI16Caller.h
src/common/SourceI32Caller.h

Review, why override?
src/flowgraph/SinkFloat.h
src/flowgraph/SinkI32.h
src/flowgraph/SourceI8_24.h

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant