Update URL paths and remove unused code #2118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gino-m
requested changes
Dec 5, 2024
| private static readonly JOB_ID_FRAGMENT_PARAM = 'job'; | ||
| private static readonly LOI_ID_FRAGMENT_PARAM = 'site'; | ||
| private static readonly SUBMISSION_ID_FRAGMENT_PARAM = 'submission'; | ||
| private static readonly TASK_ID_FRAGMENT_PARAM = 'task'; |
There was a problem hiding this comment.
Hi @amysorto ! This will rename the fragments, but we also need the router to use the URI rather than URL fragment. The exact patterns are described in the issue descriptions. Please lmk if you have any questions!
|
@amysorto Gentle ping! |
|
I deleted everything inside |
gino-m
requested changes
Dec 11, 2024
| @@ -95,6 +95,21 @@ const routes: Routes = [ | |||
| component: TermsComponent, | |||
| canActivate: [AuthGuard], | |||
| }, | |||
| { | |||
| path: `${NavigationService.SURVEY_SEGMENT}/:${NavigationService.SURVEY_ID}/${NavigationService.LOI_SEGMENT}/:${NavigationService.LOI_ID}`, | |||
There was a problem hiding this comment.
Can we use destructuring assignment to make these constants more readable? ie somewhere above const {SURVEY_SEGMENT, LOI_SEGMENT, ...} = NavigationService;?
| this.setFragmentParams(new HttpParams({fromString: ''})); | ||
| showSubmissionDetail(surveyId: string, loiId: string, submissionId: string) { | ||
| this.router.navigateByUrl( | ||
| `${NavigationService.SURVEY_SEGMENT}/${surveyId}/${NavigationService.LOI_SEGMENT}/${loiId}/${NavigationService.SUBMISSION_SEGMENT}/${submissionId}` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1243
Also removed
LOI_JOB_ID_FRAGMENT_PARAMsince it not currently being used