Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FALSE NEGATIVE]: go panic(source) and defer panic(source) #231

Open
vinayakankugoyal opened this issue Dec 16, 2020 · 0 comments
Open

[FALSE NEGATIVE]: go panic(source) and defer panic(source) #231

vinayakankugoyal opened this issue Dec 16, 2020 · 0 comments

Comments

@vinayakankugoyal
Copy link
Member

vinayakankugoyal commented Dec 16, 2020

False negative report

levee treats panic as a sink but does not create a report for the cased below when AllowPanicOnTaintedValues=false (default config)

func Oops() {
    go panic(Source{"sensitive data"})
}

func OopsIDidItAgain() {
    defer panic(Source{"sensitive data"})
}

(We are assuming that Source has been configured as a source and Sink has been configured as a sink.)

@vinayakankugoyal vinayakankugoyal changed the title [FALSE NEGATIVE]: go panic(source) [FALSE NEGATIVE]: go panic(source) and defer panic(source) Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant