From 5f4620616cbea20dca03ecf0ea29dfcd824114e3 Mon Sep 17 00:00:00 2001 From: Pascal Muetschard Date: Mon, 11 Feb 2019 10:50:08 +0000 Subject: [PATCH] Fix the robot invocation of `gapit trace`. --- test/robot/trace/client.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/robot/trace/client.go b/test/robot/trace/client.go index 111f0f2c90..1600c72d9f 100644 --- a/test/robot/trace/client.go +++ b/test/robot/trace/client.go @@ -155,12 +155,11 @@ func doTrace(ctx context.Context, action string, in *Input, store *stash.Client, params := []string{ "trace", "-out", tracefile.System(), - "-apk", subject.System(), "-for", traceTime.String(), "-disable-pcs", "-observe-frames", strconv.Itoa(observeEveryNthFrame), "-record-errors", - "-gapii-device", d.Instance().Serial, + "-serial", d.Instance().Serial, "-api", in.GetHints().GetAPI(), } @@ -174,9 +173,11 @@ func doTrace(ctx context.Context, action string, in *Input, store *stash.Client, defer func() { file.Remove(obb) }() - params = append(params, "-obb", obb.System()) + // TODO fix this + // params = append(params, "-obb", obb.System()) + return log.Errf(ctx, nil, "OBBs are currently not supported") } - cmd := shell.Command(gapit.System(), params...) + cmd := shell.Command(gapit.System(), append(params, "apk:"+subject.System())...) outBuf := &bytes.Buffer{} errBuf := &bytes.Buffer{} outputObj := &Output{}