Skip to content
This repository has been archived by the owner on Aug 5, 2024. It is now read-only.

Continuous Integration #3

Open
FranklinYu opened this issue Feb 21, 2018 · 6 comments
Open

Continuous Integration #3

FranklinYu opened this issue Feb 21, 2018 · 6 comments

Comments

@FranklinYu
Copy link

It would help if we sets up continuous integration, to make sure that pull requests won’t break anything.

@mithuns
Copy link

mithuns commented May 21, 2018

Would travis-ci work ? Or is there a preference on the ci tool ?

@FranklinYu
Copy link
Author

@mithuns Travis CI is the most popular one, but there are many out there (like Semaphore, CircleCI, Codeship). Any of them would help.

Note that Travis CI (and many others) doesn't support Windows, so typically they are combined with AppVeyor, the only Windows player in town (AFAIK).

@mithuns
Copy link

mithuns commented May 23, 2018

Okay, but I think I would wait till #2 gets merged, for others, I am not so sure, like the cpp needs a csproj and the c# code would need a .sln file in order for them to be buildable, right.
May be we can do separate pull requests for each of them.
Suggestions ?

@FranklinYu
Copy link
Author

FranklinYu commented May 23, 2018

.csproj is for C#. The current C++ implementation seems to use QMake to build. I prefer calling it "Qt implementation" than a "C++ implementation" because Qt is a hard compile time requirement.

At least we can start testing Python versions? The JavaScript version also needs to be updated after #13.

@mithuns
Copy link

mithuns commented May 29, 2018

@FranklinYu hey, so I created something to try out, the python builds are showing success, but seems like no tests are being run, can you please take a look and suggest something.
https://travis-ci.org/mithuns/diff-match-patch/jobs/384997323

@FranklinYu
Copy link
Author

@mithuns I think it has to do with test discovery. I suggest not investing too much time in this unless @NeilFraser show interest, because IIUC he is the maintainer of this repository.

lofcz pushed a commit to lofcz/diff-match-patch that referenced this issue Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants