From 158ed9a7b3205341e4e5ece2dda413e7b2020afc Mon Sep 17 00:00:00 2001 From: Lokbondo Kung Date: Fri, 20 Dec 2024 00:38:43 -0800 Subject: [PATCH] [dawn] Suppress more multithread device dropping tests. - Suppressing these tests because they are crashing in new VVL rolls. More details in the bug. Bug: 383339997 Change-Id: Id6fb944b17bad26007397193ccb5b6a4f962a8a2 Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/220134 Auto-Submit: Loko Kung Commit-Queue: Loko Kung Reviewed-by: Kai Ninomiya --- src/dawn/tests/end2end/MultithreadTests.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/dawn/tests/end2end/MultithreadTests.cpp b/src/dawn/tests/end2end/MultithreadTests.cpp index a2b68e902c..63b7850e7c 100644 --- a/src/dawn/tests/end2end/MultithreadTests.cpp +++ b/src/dawn/tests/end2end/MultithreadTests.cpp @@ -119,10 +119,10 @@ TEST_P(MultithreadTests, Device_DroppedOnAnotherThread) { // TODO(crbug.com/dawn/1779): This test seems to cause flakiness in other sampling tests on // NVIDIA. DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia()); - // TODO(crbug.com/42240870): Flaky on Linux TSAN Release - // TODO(crbug.com/383339997): Failing on Linux/Vulkan. - DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan()); + DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsTsan()); + // TODO(crbug.com/383339997): Failing on Linux/Vulkan with VVL. + DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsBackendValidationEnabled()); std::vector devices(5); @@ -159,6 +159,9 @@ TEST_P(MultithreadTests, Device_DroppedInCallback_OnAnotherThread) { // NVIDIA. DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia()); + // TODO(crbug.com/383339997): Failing on Linux/Vulkan with VVL. + DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsBackendValidationEnabled()); + std::vector devices(10); // Create devices. @@ -208,6 +211,9 @@ TEST_P(MultithreadTests, Device_WaitForDroppedInAnotherThread) { // NVIDIA. DAWN_SUPPRESS_TEST_IF(IsD3D12() && IsNvidia()); + // TODO(crbug.com/383339997): Failing on Linux/Vulkan with VVL. + DAWN_SUPPRESS_TEST_IF(IsLinux() && IsVulkan() && IsBackendValidationEnabled()); + enum class Step { Begin, Waiting,