Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depedency on cordova-plugin-compat #26

Open
sebastian-zarzycki-apzumi opened this issue Mar 20, 2018 · 9 comments
Open

Remove depedency on cordova-plugin-compat #26

sebastian-zarzycki-apzumi opened this issue Mar 20, 2018 · 9 comments

Comments

@sebastian-zarzycki-apzumi

When using this for cordova-android 7.1.0, it complains about the failed requirement

cordova platform add android
(...)
Installing "cordova-plugin-browsertab" for android
Plugin dependency "[email protected]" already fetched, using that version.
Installing "cordova-plugin-compat" for android
Plugin doesn't support this project's cordova-android version. cordova-android: 7.1.0, failed version requirement: 
      <6.3.0
Skipping 'cordova-plugin-compat' for android
Subproject Path: CordovaLib
Subproject Path: app
Installing "cordova-plugin-compat" for android
Plugin doesn't support this project's cordova-android version. cordova-android: 7.1.0, failed version requirement: 
      <6.3.0
Skipping 'cordova-plugin-compat' for android
@ghost
Copy link

ghost commented Apr 4, 2018

+1 same issue.

@ghost
Copy link

ghost commented Apr 5, 2018

I solved this issue by, downloading the browsertab plugin first and then removing the dependency code in plugins xml file and then removing and adding the cordova-android 6.4.0 and it worked.

I believe it will work the same way in other above version too.

@sebastian-zarzycki-apzumi
Copy link
Author

That's not a reliable solution, it will work only on your local machine.

@ghost
Copy link

ghost commented Apr 5, 2018

I just suggested if you want to make it build now. Else somebody has to make changes and give new git commit and google has to approve it.

@rtm
Copy link

rtm commented Jun 20, 2018

I see that there is a version 0.2.1 in the repo, which has the dependency removed, but it has never been published to npm. Can someone please publish it?

@fmalave
Copy link

fmalave commented Oct 4, 2018

That's not a reliable solution, it will work only on your local machine.

Hi, @sebastian-zarzycki-es
Did you find an alternative solution to this?

@sebastian-zarzycki-apzumi
Copy link
Author

I don't remember, honestly. I think I've patched the plugin locally, like @sanvenkur suggested. There's not much to be done, just ask the original maintainer to, well, maintain his work.

@fmalave
Copy link

fmalave commented Oct 5, 2018

I don't remember, honestly. I think I've patched the plugin locally, like @sanvenkur suggested. There's not much to be done, just ask the original maintainer to, well, maintain his work.

Thanks, I'll try something.

@Mdelaf
Copy link

Mdelaf commented Jan 23, 2019

No solution yet? I don't want to patch the plugin locally 😑

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants