-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close method not working and showing ambiguous console warning #18
Comments
I am having the same iOS issue (Ionic 3, using https://github.com/EddyVerbruggen/Custom-URL-scheme). The browser remains open in the foreground, but my Android works fine. Originally it would open the browser, close the browser, but would not re open the app (I had to relaunch the app manually which then had the URL available. FYI to solve this I added the following to my @madhavchaturvedi12 Any luck with getting iOS working? |
Nope. I am using ionic 2, I am trying calling |
My use case is for OAuth as well, which as you say InAppBrowser is not suited for (security issues and usability as no shared session state with system browser). On auth success, my backend sends a HTTP redirect to the custom URL scheme, but the BrowserTab does not close automatically/redirect the user back to the app even though the app receives the call back. I have also tried the following:
I'm not experiencing your 2nd issue where the BrowserTab does not launch consistently. Everything works fine for me, expect the the user needs to tap 'Done' to close the BrowserTab after the OAuth flow to return to the app. I using |
We had the same issue with OAuth with BrowserTab until we did a custom URL scheme which for some reason closes the tab when called. So instead of: We've had instances where we have to call this twice to get it to close for some reason. The /close part of the custom URL has no known significance, but the "myapp://" part of the URL somehow triggers your app and closes the BrowserTab. |
WOW! great work around @heberallred |
@ltlbsteed on our team actually found this solution in an article somewhere, and implemented it into our code. I figured I would post here for the benefit of anyone who is trying to solve this issue because it can use up a lot of time to solve. If the main thread of the program didn't freeze while the BrowserTab is open, then it would be a non-issue because the main thread could close it, but for now this is the only work-around we've found. |
I am trying to implement OAuth with BrowserTab, I have successfully opened a BrowserTab with
.openUrl()
and also implemented deeplinks and through that its successfully opens my app and my app continues to work, I am able to pass on the control to my app in Android , But in iOS deeplinks works fine but my app continues in background only BrowserTab remains on foreground and i am trying to close the BrowserTab through close() method it doesn't work and says:I am using chrome inspector
here is my code snippet:
Seems like there is problem with the BrowserTab API since console warning doesn't make sense, I tried removing and installing the plugin again doesn't work.
Also, how should I go about closing the BrowserTab if this isn't the correct way.
The text was updated successfully, but these errors were encountered: