From b8fe94f2de85d55dd58716849fd9dd8d428069f4 Mon Sep 17 00:00:00 2001 From: Dillon Sharlet Date: Thu, 16 Jan 2025 20:14:22 -0800 Subject: [PATCH] Disable AVX512 FP16 on MSVC It seems to be producing incorrect results: https://github.com/google/XNNPACK/actions/runs/12819708705/job/35748553217 PiperOrigin-RevId: 716487007 --- CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeLists.txt b/CMakeLists.txt index 4e415c05fd9..00424e60709 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -264,6 +264,8 @@ ELSEIF(CMAKE_C_COMPILER_ID STREQUAL "Clang") IF(CMAKE_C_COMPILER_VERSION VERSION_LESS "15") SET(XNNPACK_ENABLE_AVX512FP16 OFF) ENDIF() +ELSEIF(CMAKE_C_COMPILER_ID STREQUAL "MSVC") + SET(XNNPACK_ENABLE_AVX512FP16 OFF) ENDIF() OPTION(XNNPACK_ENABLE_HVX "Build XNNPACK with Hexagon HVX micro-kernels" ON) OPTION(XNNPACK_ENABLE_KLEIDIAI "Use KleidiAI GEMM microkernels for Arm" ON)