Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Android Kotlin Fundamentals codelab: GridLayoutManager.VERTICAL should be HORIZONTAL #41

Closed
aminsoheyli opened this issue Feb 14, 2020 · 2 comments
Closed

Android Kotlin Fundamentals codelab: GridLayoutManager.VERTICAL should be HORIZONTAL #41

aminsoheyli opened this issue Feb 14, 2020 · 2 comments
Labels
typo

Comments

@aminsoheyli
Copy link

aminsoheyli commented Feb 14, 2020 •
edited
Loading

Describe the problem

mistake

In the last paragraph where this text written:

  1. Change the span count to 5 and the direction to GridLayoutManager.VERTICAL.

The VERTICAL in the text is a mistake, it must be HORIZONTAL like as the written text and code after it.

In which lesson and step of the codelab can this issue be found?
Lesson 7.3 + task 4 + step 2.

How to reproduce?
Instead of incorrect VERTICAL it must be HORIZONTAL like as following:

  1. Change the span count to 5 and the direction to GridLayoutManager.HORIZONTAL

codelab: android-kotlin-fundamentals
@aminsoheyli aminsoheyli changed the title Android Kotlin Fundamentals codelab: 7.3 Android Kotlin Fundamentals codelab: Feb 14, 2020
@kkuan2011 kkuan2011 added the typo label Aug 11, 2020
@kkuan2011 kkuan2011 changed the title Android Kotlin Fundamentals codelab: Android Kotlin Fundamentals codelab: GridLayoutManager.VERTICAL should be HORIZONTAL Aug 11, 2020
@kkuan2011 kkuan2011 mentioned this issue Aug 11, 2020
Closed
k12e5989 pushed a commit to k12e5989/android-kotlin-fundamentals-apps that referenced this issue Dec 2, 2020
@android-dev-lxl
Merge pull request google-developer-training#41 from google-developer…
fa3a69f 
…-training/retrofit-callbacks

Update the Retrofit version
@mustafaali10
Copy link

Can I fix this typo ?

@mustafaali10
Copy link

@aminsoheyli @kkuan2011

Made a Pull Request with the number #828

If it's cool you may merge it !

Regards
Mustafa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
typo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kkuan2011 @aminsoheyli @jlulovics @mustafaali10