From 7042ebcbe097f305ba3a93f9a22b4befa4b83d29 Mon Sep 17 00:00:00 2001 From: Roland Shoemaker Date: Wed, 4 Dec 2024 10:46:07 -0800 Subject: [PATCH] openpgp/clearsign: just use rand.Reader in tests Instead of a convoluted fake rand, it is _basically_ just as fast, and fixes errors that pop up due to bad entropy. Fixes golang/go#70682 Change-Id: Ib0f605398d1092b516b03135f602c644be2a060f Reviewed-on: https://go-review.googlesource.com/c/crypto/+/633655 Reviewed-by: Tatiana Bradley LUCI-TryBot-Result: Go LUCI Auto-Submit: Roland Shoemaker Reviewed-by: Filippo Valsorda --- openpgp/clearsign/clearsign_test.go | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/openpgp/clearsign/clearsign_test.go b/openpgp/clearsign/clearsign_test.go index 051b8f16ff..821c35ff47 100644 --- a/openpgp/clearsign/clearsign_test.go +++ b/openpgp/clearsign/clearsign_test.go @@ -123,24 +123,12 @@ func TestSigning(t *testing.T) { } } -// We use this to make test keys, so that they aren't all the same. -type quickRand byte - -func (qr *quickRand) Read(p []byte) (int, error) { - for i := range p { - p[i] = byte(*qr) - } - *qr++ - return len(p), nil -} - func TestMultiSign(t *testing.T) { if testing.Short() { t.Skip("skipping long test in -short mode") } - zero := quickRand(0) - config := packet.Config{Rand: &zero} + var config packet.Config for nKeys := 0; nKeys < 4; nKeys++ { nextTest: