Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make packages be independent of config package #16

Open
rShetty opened this issue Feb 15, 2019 · 5 comments
Open

Make packages be independent of config package #16

rShetty opened this issue Feb 15, 2019 · 5 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rShetty
Copy link
Contributor

rShetty commented Feb 15, 2019

  • currently packages are dependent on config package
  • make them independent by injecting config rather depending on them through package
@rShetty rShetty added help wanted Extra attention is needed good first issue Good for newcomers labels Feb 15, 2019
@RajatVaryani
Copy link

@rShetty Can I pick this up?

@rShetty
Copy link
Contributor Author

rShetty commented Feb 18, 2019

@RajatVaryani Sure go ahead, thanks

@RajatVaryani
Copy link

@rShetty Before starting just want to understand how injecting it would help. I am still unclear.

@rShetty
Copy link
Contributor Author

rShetty commented Feb 25, 2019

@RajatVaryani The plan was that since we have tight dependency to config package from other packages with some packages needing to depend on a global object in config package, it is difficult to use some of these packages in isolation. The idea was to make it injectable so that we remove dependency on it

@SameerKhurana
Copy link

@rShetty is it still required ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants