Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 [Feature]: Add golangci-lint #68

Closed
3 tasks done
leonklingele opened this issue Feb 23, 2024 · 4 comments · Fixed by #79
Closed
3 tasks done

🚀 [Feature]: Add golangci-lint #68

leonklingele opened this issue Feb 23, 2024 · 4 comments · Fixed by #79
Assignees
@gaby
Labels
👍 Accepting PR ✏️ Feature

Comments

@leonklingele
Copy link
Member

Feature Description

Should use the same config as on the main repo.

Additional Context (optional)

No response

Code Snippet (optional)

No response

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my suggestion prior to opening this one.
  • I understand that improperly formatted feature requests may be closed without explanation.
@gaby
Copy link
Member

gaby commented Feb 24, 2024

Maybe we should move this config to https://github.com/gofiber/.github

@ReneWerner87
Copy link
Member

yes for this we have the task
https://github.com/orgs/gofiber/projects/3?pane=issue&itemId=45462785

@gaby gaby self-assigned this Mar 26, 2024
@gaby
Copy link
Member

gaby commented Apr 3, 2024

I'm almost done with this one

@gaby gaby mentioned this issue Apr 8, 2024
Merged
@gaby
Copy link
Member

gaby commented Apr 11, 2024

Fixed by #79

@gaby gaby closed this as completed Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaby gaby

Labels
👍 Accepting PR ✏️ Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Unit-Tests Coverage and CI Workflows gofiber/utils
3 participants
@gaby @leonklingele @ReneWerner87