Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly sign and notarize macOS build #49

Open
valentinegb opened this issue Dec 12, 2023 · 6 comments
Open

Properly sign and notarize macOS build #49

valentinegb opened this issue Dec 12, 2023 · 6 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@valentinegb
Copy link
Contributor

Godot version

4.2.stable

System information

macOS 14.2, M1

Issue description

This software is ineligible for submission to Homebrew (a popular package manager for macOS) as a cask because it is not properly signed and notarized.

Steps to reproduce

See Homebrew/homebrew-cask#162337.

Minimal reproduction project

N/A

@fire
Copy link
Member

fire commented Dec 12, 2023

As I am completing godotengine/godot#81746, there's been less focus on FBX2GLTF.

We discovered ufbx gave better results than FBX2GLTF.

I was not able to compile FBX2GLTF outside of Github actions, so no new features were added since that broke.

Suggestions welcome.

@valentinegb
Copy link
Contributor Author

I think it's still possible to notarize the macOS artifact in the workflow file without revealing Apple Developer credentials using GitHub Action Secrets. I'm reading up on this article right now: https://developer.apple.com/documentation/security/notarizing_macos_software_before_distribution/customizing_the_notarization_workflow

@fire
Copy link
Member

fire commented Dec 12, 2023

Please let me know how I can assist. I'm juggling too many projects at the moment and won't be able to help much.

# Ideally a stand alone tool can be like this https://github.com/ufbx/ufbx-rust.
# But I am not interested in rust and I've already implemented this in Godot Engine fbx -> godot engine scene format -> gltf
ufbx -i input.fbx -o output.glb

@valentinegb
Copy link
Contributor Author

I'll probably make a draft pull request for this pretty soon, but someone else would still need to have an Apple Developer account since I'm unfortunately currently ineligible for one.

@stelf
Copy link

stelf commented Feb 12, 2024

to be honest, I just lost like 3 days trying to build from the original source, updating conan scripts from 1.x to 2.x.

if a working macos build via brew exists, this would be great relief. so fingers crossed u can get it done @valentinegb

@valentinegb
Copy link
Contributor Author

so fingers crossed u can get it done @valentinegb

Sorry •.•'

#50 (comment)

@fire fire added enhancement New feature or request help wanted Extra attention is needed labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants