Enable turning on volume encryption #80
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chadlwilson Any chance of getting this merged and released at some point? It would really help keep our security team happy. |
|
@Rwwn I'd love to do so, and can see the value, just a bit painful and time consuming to sanity check, and I am largely a one-man band :( Have you sanity tested yourself with a build off this PR or with Windows perhaps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've only implemented this for Linux because I have no easy way of testing this on Windows agents
It appears to be working as expected on the sandbox cluster I have tested it on, but I would appreciate further testing on other clusters. This is my first major contribution to this plugin, and I've done a bit of guessing at how it all works, so all feedback greatfully received.