Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from RequestSpotInstances API #390

Open
chadlwilson opened this issue Dec 10, 2024 · 0 comments
Open

Migrate away from RequestSpotInstances API #390

chadlwilson opened this issue Dec 10, 2024 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@chadlwilson
Copy link
Member

Currently the plugin seems to rely upon this API to get spot instances. According to https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RequestSpotInstances.html this API is deprecated.

I'm not sure what the best alternative is for this plugin from https://docs.aws.amazon.com/en_us/AWSEC2/latest/UserGuide/spot-best-practices.html however at the same time it'd be good to move away from the code this plugin uses to get spot instances

  • avoid manual code-based selection of target subnet based on least instances (this leads to trying to create instances in an AZ that has a capacity problem repeatedly, which is not great)
    • plugin should support just giving it a few subnets and let it create instances based on capacity
  • allow different capacity strategies, preferably delegates to AWS (maybe via CreateFleet)
@chadlwilson chadlwilson added the help wanted Extra attention is needed label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant