Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many numerical values are stored as strings #112

Open
oobayly opened this issue Feb 27, 2024 · 0 comments
Open

Many numerical values are stored as strings #112

oobayly opened this issue Feb 27, 2024 · 0 comments

Comments

@oobayly
Copy link

oobayly commented Feb 27, 2024

Properties that contain number, such as GoCardless.Resources.TaxRate.Percentage or GoCardless.Resources.PayoutItem.Amount are presented as strings. This makes very little sense as they're numbers, and raises a few questions:

  1. Can they be null or an empty string, or are they guaranteed to be parsed safely?
  2. What locale do we parse them in?
  3. Are we guaranteed that the decimal separator is always .,
  4. Are we guaranteed that there will never be a decimal separator.

It seems a bizarre decision to make, especially as other properties are integers, eg. GoCardless.Resources.Payout.Amount, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant