Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove package guard against ARM64 #164

Closed
michael-schwarz opened this issue Jan 26, 2024 · 4 comments
Closed

Remove package guard against ARM64 #164

michael-schwarz opened this issue Jan 26, 2024 · 4 comments
Labels
Milestone

Comments

@michael-schwarz
Copy link
Member

@DrMichaelPetter tested on MacOS Sonoma 14.3 (M1 Pro CPU) today, and CIL works fine on there. We should remove the package guard in OPAM to facilitate students working with it and release a new goblint-cil version.

@sim642
Copy link
Member

sim642 commented Feb 1, 2024

#154 needs to be handled for this.

@sim642 sim642 added this to the 2.0.4 milestone Feb 1, 2024
@sim642
Copy link
Member

sim642 commented Jul 26, 2024

The test from #154 doesn't seem to fail in GitHub CI on OSX arm64 now. I wonder if the opam-repository CI machines are somehow different.

@DrMichaelPetter Do all CIL tests pass on your M1 Mac? CIL may build and install fine regardless, because opam doesn't usually run tests for packages.

@DrMichaelPetter
Copy link

dune test runs through without hickups on my M1 Mac

@sim642
Copy link
Member

sim642 commented Jul 30, 2024

I've relaxed the availability to allow for arm64 in 8f9b0c6.

@sim642 sim642 closed this as completed Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants