Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both branches dead in char_generic_nvram_read_nvram_write_nvram.i with octagon enabled analysis #1498

Closed
DrMichaelPetter opened this issue Jun 3, 2024 · 5 comments · Fixed by #1492
Labels
bug sv-comp SV-COMP (analyses, results), witnesses unsound
Milestone

Comments

@DrMichaelPetter
Copy link
Collaborator

The following popped up when doing extensive benchmarking, so by creduce we get:

//SKIP PARAM: --set ana.activated[+] apron --set ana.apron.domain octagon --set sem.int.signed_overflow assume_none

#include <pthread.h>
#include <stdlib.h>

long *a;
pthread_t e;
void* b() {
  long c = *a;
  for (; (void*)0;) c=c;
}
int main() {
  a = malloc(sizeof(long));
  pthread_create(&e, 0, b, 0);
}

This gives us a [Error][Analyzer][Unsound] both branches over condition '(void *)0' are dead (line:10:7-10:19) , which is the void* bit

I have not much time right now to debug this myself, so I put it in an issue.

@sim642
Copy link
Member

sim642 commented Jun 3, 2024

This seems to be the same thing as #1440 came to.

@michael-schwarz
Copy link
Member

Does #1492 fix the issue?

@DrMichaelPetter
Copy link
Collaborator Author

Does #1492 fix the issue?

Actually it does, you are right

@DrMichaelPetter DrMichaelPetter linked a pull request Jun 3, 2024 that will close this issue
2 tasks
@michael-schwarz
Copy link
Member

Great to hear!

@DrMichaelPetter
Copy link
Collaborator Author

Great to hear!

Maybe this can serve as another regression test, then.

@sim642 sim642 added the sv-comp SV-COMP (analyses, results), witnesses label Jun 4, 2024
@sim642 sim642 added this to the v2.4.0 milestone Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug sv-comp SV-COMP (analyses, results), witnesses unsound
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants