Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Z module directly #1317

Closed
sim642 opened this issue Jan 10, 2024 · 0 comments · Fixed by #1329
Closed

Use Z module directly #1317

sim642 opened this issue Jan 10, 2024 · 0 comments · Fixed by #1329
Assignees
@karoliineh
Labels
cleanup Refactoring, clean-up good first issue
Milestone
v2.4.0

Comments

@sim642
Copy link
Member

sim642 commented Jan 10, 2024

Many places are very verbose and use IntOps.BigIntOps or an abbreviated BI module to work with big integers from Zarith.
Their type is fixed to be Z.t, so we should just use the Z module directly whereever possible. It's shorter and more consistent.
@sim642 sim642 added cleanup Refactoring, clean-up good first issue labels Jan 10, 2024
@sim642 sim642 added this to the v2.4.0 milestone Jan 10, 2024
@karoliineh karoliineh self-assigned this Jan 15, 2024
@karoliineh karoliineh mentioned this issue Jan 15, 2024
Merged
@sim642 sim642 linked a pull request Jan 29, 2024 that will close this issue
Use Z module directly #1329
Merged
@stilscher stilscher mentioned this issue Jan 30, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karoliineh karoliineh

Labels
cleanup Refactoring, clean-up good first issue
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging a pull request may close this issue.

Use Z module directly goblint/analyzer
2 participants
@sim642 @karoliineh