Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooks are not executed for v9 #75

Open
cjweber opened this issue Jun 16, 2023 · 2 comments
Open

Hooks are not executed for v9 #75

cjweber opened this issue Jun 16, 2023 · 2 comments

Comments

@cjweber
Copy link

cjweber commented Jun 16, 2023 •
edited
Loading

After updating to go-redis v9, I found that the custom hooks we have are not executed when added to the mock client.

The PR I made #74 addresses it and fixes the problem for me.

I would like to understand if there is any intention to support added hooks moving forward, and if there is any reason why my PR doesn't address it in the desired way.
@cjweber
Copy link
Author

cjweber commented Nov 20, 2023

@monkey92t Any chance my PR can get addressed? Happy to change it if it isn't satisfactory. I confirmed it fixes my issue locally.

@ste93cry
Copy link

ste93cry commented Jan 3, 2025

I also stumbled upon this issue, and would love to see it fixed. Is there any chance to get a comment from maintainers on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ste93cry @cjweber