Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix length check on dns_rfc1035_label tag #1214

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix length check on dns_rfc1035_label tag #1214

wants to merge 1 commit into from

Conversation

KimNorgaard
Copy link

Fixes Or Enhances

Fix length check on dns_rfc1035_label tag.

Fixes #1213

Make sure that you've checked the boxes below before you submit PR:

  • Tests exist or have been written that cover this particular change.

@go-playground/validator-maintainers

@KimNorgaard KimNorgaard requested a review from a team as a code owner January 12, 2024 08:51
@coveralls
Copy link

Coverage Status

coverage: 73.909% (+0.006%) from 73.903%
when pulling 870ae2f on KimNorgaard:fix-rfc-1035-label-length-check
into 84254ae on go-playground:master.

zemzale
zemzale approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@zemzale zemzale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zemzale zemzale zemzale approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC1035 DNS Labels can be more than 63 characters long
3 participants
@KimNorgaard @coveralls @zemzale