Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge logic should try harder to merge series when 1 is of different length. #22

Open
nnuss opened this issue Sep 28, 2016 · 1 comment
Milestone

Comments

@nnuss
Copy link
Collaborator

nnuss commented Sep 28, 2016

mergeValues() will set responseLengthMismatch = true on the first case where there is a length mismatch and prevent further attempts to merge. It can happen that that this prevents merging from a following series that has the same length.

There is a TODO nearby that hints at a proposed solution.

We believe we've seen this when requesting data right at a rollup boundary and a race condition on the carbonstores will determine if we get it's data at higher or lower resolution.

@Civil Civil added this to the 0.80 milestone Apr 25, 2017
@Civil
Copy link
Member

Civil commented Apr 25, 2017

Related to #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants