last try to make test works

go-graphite · Nov 18, 2024 · cdab347 · cdab347
1 parent 8bb9936
commit cdab347
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/expr/functions/countValues/function.go b/expr/functions/countValues/function.go
@@ -31,7 +31,7 @@ func New(_ string) []interfaces.FunctionMetadata {
 
 const (
 	defaultValuesLimit      = 32
-	LimitExceededMetricName = "error.too.many.values.limit.reached"
+	LimitExceededMetricName = "valuesLimitReached"
 )
 
 // countValues(seriesList)

diff --git a/expr/functions/countValues/function_test.go b/expr/functions/countValues/function_test.go
@@ -5,14 +5,18 @@ import (
 	"testing"
 	"time"
 
+	"github.com/go-graphite/carbonapi/expr/interfaces"
 	"github.com/go-graphite/carbonapi/expr/metadata"
 	"github.com/go-graphite/carbonapi/expr/types"
 	"github.com/go-graphite/carbonapi/pkg/parser"
 	th "github.com/go-graphite/carbonapi/tests"
 )
 
+var (
+	md []interfaces.FunctionMetadata = New("")
+)
+
 func init() {
-	md := New("")
 	for _, m := range md {
 		metadata.RegisterFunction(m.Name, m.F)
 	}
@@ -90,7 +94,7 @@ func TestCountValues(t *testing.T) {
 			},
 			"countValues",
 			map[string][]*types.MetricData{
-				LimitExceededMetricName: {types.MakeMetricData(LimitExceededMetricName, []float64{0, 0, 0, 0, 0}, 1, now32)},
+				"valuesLimitReached": {types.MakeMetricData("valuesLimitReached", []float64{0, 0, 0, 0, 0}, 1, now32)},
 			},
 		},
 		{
@@ -105,15 +109,15 @@ func TestCountValues(t *testing.T) {
 			},
 			"countValues",
 			map[string][]*types.MetricData{
-				LimitExceededMetricName: {types.MakeMetricData(LimitExceededMetricName, []float64{0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 1, now32)},
+				"valuesLimitReached": {types.MakeMetricData("valuesLimitReached", []float64{0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, 1, now32)},
 			},
 		},
 	}
 
 	for _, tt := range tests {
 		t.Run(tt.Target, func(t *testing.T) {
 			eval := th.EvaluatorFromFunc(md[0].F)
-			th.TestEvalExprWithRange(t, eval, &tt)
+			th.TestMultiReturnEvalExpr(t, eval, &tt)
 		})
 	}