Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unsafe renderer so it always generates what we tell it to #128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

777arc
Copy link
Member

@777arc 777arc commented Dec 27, 2023

When I tried generating the pages locally by running hugo I noticed it wasnt including <img src... tags, but instead replacing them with <!-- raw HTML omitted --> and this fixes it, in one of the recent releases this started happening https://discourse.gohugo.io/t/raw-html-getting-omitted-in-0-60-0/22032

@marcusmueller
Copy link
Member

I'm not a fan – you can include images with ![…](…), and unlike <img src that will correctly include the resources in the build

@777arc
Copy link
Member Author

777arc commented Dec 27, 2023

But then we would have to go through all the old html right?

@marcusmueller
Copy link
Member

yes, but my understanding is that without that, the images wouldn't be part of what gets deployed, anyways, right?

@777arc
Copy link
Member Author

777arc commented Dec 27, 2023

Only if we were to update hugo, which we don't have to

@marcusmueller
Copy link
Member

Only if we were to update hugo, which we don't have to

I don't understand. in the old blog entries, the included images, they never get uploaded to any webserver, because hugo doesn't know how to find them, even if we allow <img tags, right?

By the way, all the local images I can find in a quick scan (``) in <img src= have URLs that start with `https://gnuradio.org/wp-content/uploads/{year}/{month}`; they wouldn't work, anyways, so we'd have to manually fix these URLs anways

@777arc 777arc marked this pull request as draft April 26, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants