Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a member of a role is disabled as a module we should show it #9

Open
asgeir-s opened this issue Feb 19, 2022 · 1 comment
Open

Comments

@asgeir-s
Copy link

asgeir-s commented Feb 19, 2022

If enabledAsModule in the subgraph's Member entity is false we should indicate it to the user. Because the member will not be able to execute transactions even though it is a member of the role.

This can happen if the Roles Modifier's owner (usually the avatar) calls the disableModule function.

@asgeir-s
Copy link
Author

@cedricwaxwing: Reaching this scenario is not easily achievable, it will require somebody to execute a transaction from the Avatar to the module's disableModule function (this is not exposed in any UI). Therefore, I am not sure this is required for https://github.com/gnosis/zodiac-modifier-roles/milestone/1 🤔

@jfschwarz jfschwarz transferred this issue from gnosisguild/zodiac-modifier-roles Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant