From 52dd472dc6e6d4c718224e4d08699a9260910679 Mon Sep 17 00:00:00 2001
From: piux2 <90544084+piux2@users.noreply.github.com>
Date: Wed, 13 Nov 2024 18:33:09 -0800
Subject: [PATCH 1/2] fix: prevent false positive return for guarding member
 store

If we want to guard the MemStore by checking the active DAO realm, m.daoPkgPath must first be assigned a realm package path; otherwise, the isCallerDAORealm() method may return a false positive, failing to protect the MemStore.
---
 examples/gno.land/p/demo/membstore/membstore.gno | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/gno.land/p/demo/membstore/membstore.gno b/examples/gno.land/p/demo/membstore/membstore.gno
index 6e1932978d9..ca721d078e6 100644
--- a/examples/gno.land/p/demo/membstore/membstore.gno
+++ b/examples/gno.land/p/demo/membstore/membstore.gno
@@ -205,5 +205,5 @@ func (m *MembStore) TotalPower() uint64 {
 // the API of the member store is public and callable
 // by anyone who has a reference to the member store instance.
 func (m *MembStore) isCallerDAORealm() bool {
-	return m.daoPkgPath == "" || std.CurrentRealm().PkgPath() == m.daoPkgPath
+	return m.daoPkgPath != "" && std.CurrentRealm().PkgPath() == m.daoPkgPath
 }

From 7b251fb2eeb1df1d1ec0621a1e96a0466efac2c9 Mon Sep 17 00:00:00 2001
From: piux2 <90544084+piux2@users.noreply.github.com>
Date: Mon, 9 Dec 2024 20:27:53 -0800
Subject: [PATCH 2/2] fix test

---
 examples/gno.land/r/gov/dao/v2/dao.gno | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/gno.land/r/gov/dao/v2/dao.gno b/examples/gno.land/r/gov/dao/v2/dao.gno
index 9263d8d440b..5ee8e63236a 100644
--- a/examples/gno.land/r/gov/dao/v2/dao.gno
+++ b/examples/gno.land/r/gov/dao/v2/dao.gno
@@ -13,6 +13,8 @@ var (
 	members membstore.MemberStore // the member store
 )
 
+const daoPkgPath = "gno.land/r/gov/dao/v2"
+
 func init() {
 	// Example initial member set (just test addresses)
 	set := []membstore.Member{
@@ -23,7 +25,7 @@ func init() {
 	}
 
 	// Set the member store
-	members = membstore.NewMembStore(membstore.WithInitialMembers(set))
+	members = membstore.NewMembStore(membstore.WithInitialMembers(set), membstore.WithDAOPkgPath(daoPkgPath))
 
 	// Set the DAO implementation
 	d = simpledao.New(members)