Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go.mod): update golang.org/x/crypto to v0.31.0, et al #3334

Closed
wants to merge 1 commit into from

Conversation

odeke-em
Copy link
Contributor

Updates:

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Dec 13, 2024

🛠 PR Checks Summary

🔴 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

Manual Checks (for Reviewers):
  • SKIP: Do not block the CI for this PR
  • The pull request description provides enough details (checked by @n2p5)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🔴 Maintainers must be able to edit this pull request (more info)
🔴 The pull request head branch must be up-to-date with its base (more info)

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Automated Checks
Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 The pull request was created from a fork (head branch repo: orijtech/gno)

Then

🔴 Requirement not satisfied
└── 🔴 Maintainer can modify this pull request

The pull request head branch must be up-to-date with its base (more info)

If

🟢 Condition met
└── 🟢 On every pull request

Then

🔴 Requirement not satisfied
└── 🔴 Head branch (orijtech:go.mod-update-dependencies) is up to date with base (master): behind by 2 / ahead by 1

Manual Checks
**SKIP**: Do not block the CI for this PR

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission
The pull request description provides enough details

If

🟢 Condition met
└── 🟢 Not (🔴 Pull request author is a member of the team: core-contributors)

Can be checked by

  • team core-contributors

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@odeke-em odeke-em force-pushed the go.mod-update-dependencies branch from 9ab7f74 to 9ed6cfe Compare December 13, 2024 15:23
Updates:
* golang.org/x/crypto to v0.31.0 from v0.26.0 in lieu of https://pkg.go.dev/vuln/GO-2024-3321
* golang.org/x/sync to v0.10.0 from v0.8.0
* golang.org/x/term to v0.27.0 from v0.23.0
@odeke-em odeke-em force-pushed the go.mod-update-dependencies branch from 9ed6cfe to e09f801 Compare December 13, 2024 15:30
@odeke-em odeke-em changed the title go.mod: update golang.org/x/crypto to v0.31.0, et al chore(go.mod): update golang.org/x/crypto to v0.31.0, et al Dec 15, 2024
@n2p5 n2p5 self-requested a review December 16, 2024 16:35
Copy link
Contributor

@n2p5 n2p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed that this PR is specific to gnolang.org/x/* dependencies.

@n2p5 n2p5 self-requested a review December 16, 2024 16:42
Copy link
Contributor

@n2p5 n2p5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @odeke-em, these changes look great, but our review bot has detected that the permissions on your branch and how up-to-date it is needs to be fixed. Can you fix these issues so that we can integrate this PR?

Specifically:

  • 🔴 Maintainers must be able to edit this pull request (more info)
  • 🔴 The pull request head branch must be up-to-date with its base (more info)

@kristovatlas kristovatlas self-requested a review December 16, 2024 16:46
@thehowl
Copy link
Member

thehowl commented Dec 20, 2024

Please re-open the PR solving conflicts and from a personal account, so we can merge in master if necessary, thank you.

@thehowl thehowl closed this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

5 participants