Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Display RAG results #108

Closed
kevin-on opened this issue Nov 19, 2024 · 14 comments · Fixed by #107
Closed

feat: Display RAG results #108

kevin-on opened this issue Nov 19, 2024 · 14 comments · Fixed by #107

Comments

@kevin-on
Copy link
Collaborator

Allow users to see the sources contributing to the model's output.

@kevin-on kevin-on converted this from a draft issue Nov 19, 2024
@kevin-on kevin-on linked a pull request Nov 19, 2024 that will close this issue
@3-ark
Copy link

3-ark commented Nov 19, 2024

Yes, also showing the semantic search results like in plug-in "smart connection" and in other rag apps, say MSTY, is very useful too.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Smart Composer Nov 20, 2024
@glowingjade
Copy link
Owner

@3-ark
Copy link

3-ark commented Nov 20, 2024

@3-ark Do you mean something like this? https://github.com/brianpetro/obsidian-smart-connections?tab=readme-ov-file#smart-chat-ai-conversations-based-on-your-notes

Yes, the results will give a number, like "0.79", "0.61" to indicate the similarity. My screenshots are more clear. The first one shows the similarity between the current opening note with others in the vault. The second shows the semantic search function of that plug-in. Msty has a similar function. I find it much better than the "outgoing links".

similarityofnotes
semanticsearch

@glowingjade
Copy link
Owner

@3-ark So the key difference is showing similarity scores, right?

@3-ark
Copy link

3-ark commented Nov 20, 2024

Difference? If you are referring to the sources (searching results), then, yes. It helps to see the relevance, sometimes model shows irrelevant result in low similarity. But the basic idea of showing the semantic searching results is the core, it let me find all the relevant notes in minutes, for me it's more useful than the generated answer itself.

@glowingjade
Copy link
Owner

glowingjade commented Nov 21, 2024

@3-ark We have just added a feature to display search results with a similarity score!
Check out the updates here and here.
The release is scheduled for today.

@3-ark
Copy link

3-ark commented Nov 21, 2024

Man, it would be another killer! Can't wait to use.

@glowingjade
Copy link
Owner

It has been released as version 1.0.6!

@3-ark
Copy link

3-ark commented Nov 21, 2024

I toyed with it a little bit, looks promising. I will get some feedback after using it more later for actual note-taking.

@3-ark
Copy link

3-ark commented Nov 21, 2024

Thanks for your great work!

@3-ark
Copy link

3-ark commented Nov 22, 2024

So far so good for me. I just tried and make a new exercise plan using new implemented Gemini 1.5 pro. my only concern is the available model list, I don't know if it could be made in a flexible way. I mean, API providers have more nodes, maybe you guys want to make the list clean but it's a little catching for you when they have new models. But if it can fetch the list automatically, then you don't have to worry about this issue anymore. The only trouble would be too many models in the list. Maybe we can solve it by whitelist in setting.

Another issue is not for me, I just want to provide one possible useful feedback. The rag searching results, now you set it to 15 in default and unchangeable. I am totally happy with this, but maybe someone wants to make it less for a better coherence (because sometimes the similarities are too low for over 10 items) or more (to check more related notes in general, or maybe this could be done by a separated searching function)

Anyway, working perfectly. I love the editing function, it's so smooth.

@3-ark
Copy link

3-ark commented Nov 22, 2024

Ah, forget to mention. Maybe when you have more users, they will ask for some popular API providers. You guys can check Jan.Ai if you want to add. Those guys are doing a great job in this part.

@glowingjade
Copy link
Owner

Thanks for your suggestions!

  1. We'll look into a better way to handle the model list.
  2. For RAG search results, you can actually customize the limit in the Advanced Configuration settings: https://github.com/glowingjade/obsidian-smart-composer/wiki/1.4-Advanced-Configuration#rag-settings
  3. Regarding Jan.ai - while I haven't checked if they support OpenAI-compatible APIs, you can use any provider that does through our custom OpenAI-compatible models option: https://github.com/glowingjade/obsidian-smart-composer/wiki/1.4-Advanced-Configuration#custom-openai-compatible-models

@3-ark
Copy link

3-ark commented Nov 23, 2024

Thanks for your suggestions!

  1. We'll look into a better way to handle the model list.
  2. For RAG search results, you can actually customize the limit in the Advanced Configuration settings: https://github.com/glowingjade/obsidian-smart-composer/wiki/1.4-Advanced-Configuration#rag-settings
  3. Regarding Jan.ai - while I haven't checked if they support OpenAI-compatible APIs, you can use any provider that does through our custom OpenAI-compatible models option: https://github.com/glowingjade/obsidian-smart-composer/wiki/1.4-Advanced-Configuration#custom-openai-compatible-models

It seems my mind was still in the last update. So, I guess it's perfect! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants