-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
triggerSibling Issue #99
Comments
Ah I know what the issue is here, it's something to do with returning the sibling as a component. I'll take a look at it shortly for this fix. |
This could be fixed if we update to check what is passed the to the triggerSibling prop. @glennflanagan is this something you would want to add? The fix here is to pass the triggerSibling a triggerSibling={() => <div>Hello<div>} so we could simply pass this as a warning in the console instead? @rsarai do you have any thoughts on this? renderNonClickableTriggerElement() {
if (this.props.triggerSibling && typeof this.props.triggerSibling === 'string') {
return (
<span className={`${this.props.classParentString}__trigger-sibling`}>{this.props.triggerSibling}</span>
)
+ } else if (typeof this.props.triggerSibling === 'object') {
+ return this.props.triggerSibling
+ } else if (typeof this.props.triggerSibling === 'function') {
+ return <this.props.triggerSibling />
+ }
return null;
} |
@mujahidateeb please let me know if this has solved your problem, re-open if you're still having problems |
I'm having the same issue as well. Doesn't look like the original issue creator ever responded. @karltaylor was the proposed fix ever implemented? It doesn't appear to have been. Thanks for your help! |
@karltaylor here is there error i see (version 2.6.0)
|
…able trigger" for styling possibility.
Hi,
I'm getting below issue while using triggerSibling can you please help me to sort out this issue
This is my sample code using
The text was updated successfully, but these errors were encountered: