Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zupfe & Octoapp conflicting? #4

Open
romanr9999 opened this issue Jul 26, 2024 · 9 comments
Open

Zupfe & Octoapp conflicting? #4

romanr9999 opened this issue Jul 26, 2024 · 9 comments
Assignees
Labels
bug Something isn't working

Comments

@romanr9999
Copy link

I noticed lately (not sure when this started) that I can't see files on Zupfe cause when loading it gives me a "xxxxx.gcode is not a G-Code file".
I also noticed that the first line on my gcode files reads "M118 E1 OCTOAPP_DISABLE_LAYER_MAXIC" and that lines makes Zupfe to give the error.
I tried commenting that line, but it get written again immediately, so I also disabled OctoApp and then Zupfe reads the file with no problem.

Am I doing something wrong or they do conflict with each other????

@crysxd
Copy link

crysxd commented Jul 27, 2024

OctoApp dev here :)

I started adding these Gcode commands in a pre-processing script to send notifications during the print. It's valid Gcode, so I'm a bit surprised this causes issues. Happy to help to troubleshoot this :)

In the meantime, downgrading to the OctoApp plugin to release 2.0.10 by installing the plugin in OctoPrint's plugin manager from this URL will "solve" the issue: https://github.com/crysxd/OctoApp-Plugin/archive/refs/tags/2.0.10.zip

@glennerichall
Copy link
Owner

Hi, I checked by adding the instruction "M118 E1 OCTOAPP_DISABLE_LAYER_MAXIC" on a gcode file and uploaded it to ZupFe, and also to an OctoPrint instance and it loads correctly into ZupFe. Could you upload one of your files here please ?

@crysxd
Copy link

crysxd commented Aug 3, 2024

This file is processed by the plugin

Calibration_Cube_Single_Filament_MMU-2_1.gcode.zip

@glennerichall
Copy link
Owner

I confirm that ZupFe fails to load properly the content of the file since there is too much failed gcode instructions found. In fact, i have set a 10% threshold for invalid gcode and since OctoApp adds gcode, in reaches this threshold. The gcode file provided by Christian will be useful to fix ZupFe and implement those missing valid gcode.

@glennerichall glennerichall added the bug Something isn't working label Aug 3, 2024
@glennerichall glennerichall self-assigned this Aug 3, 2024
@glennerichall
Copy link
Owner

Hello @crysxd, when you inject commands into the gcode from your plugin, did you check whether line endings are CR, LF or CRLF ? By inspecting your provided file, it seems that there is a combination of CRLF and LF where I suppose the original file is LF.
image

@crysxd
Copy link

crysxd commented Sep 30, 2024

Hi @glennerichall! That's correct, I always insert \r\n. Is that a problem for you?
I copied this behavior from the example provided by OctoPrint: https://github.com/OctoPrint/Plugin-Examples/blob/master/strip_all_comments.py

@glennerichall
Copy link
Owner

Hi @glennerichall! That's correct, I always insert \r\n. Is that a problem for you? I copied this behavior from the example provided by OctoPrint: https://github.com/OctoPrint/Plugin-Examples/blob/master/strip_all_comments.py

Oh it was but it will be fixed it in zupfe as this should not be. Thank you.

@crysxd
Copy link

crysxd commented Oct 1, 2024

We all love our CRLF and LF :D That caused me some trouble in the past as well. Thanks for sorting this out!

@glennerichall
Copy link
Owner

@romanr9999 I have fixed some gcode parsing errors in v1.3.54. Could you confirm that it does not conflict anymore with Octoapp ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants